2016-11-16 0:27 GMT+01:00 Russell King - ARM Linux <linux@xxxxxxxxxxxxxxx>: > On Wed, Nov 16, 2016 at 12:23:50AM +0100, Pierre-Hugues Husson wrote: >> Hi, >> >> >> 2016-11-14 16:22 GMT+01:00 Hans Verkuil <hverkuil@xxxxxxxxx>: >> > From: Russell King <rmk+kernel@xxxxxxxxxxxxxxxx> >> > >> > We don't need the CEC engine register definitions, so let's remove them. >> > >> > Signed-off-by: Russell King <rmk+kernel@xxxxxxxxxxxxxxxx> >> > --- >> > drivers/gpu/drm/bridge/dw-hdmi.h | 45 ---------------------------------------- >> > 1 file changed, 45 deletions(-) >> > >> > diff --git a/drivers/gpu/drm/bridge/dw-hdmi.h b/drivers/gpu/drm/bridge/dw-hdmi.h >> > index fc9a560..26d6845 100644 >> > --- a/drivers/gpu/drm/bridge/dw-hdmi.h >> > +++ b/drivers/gpu/drm/bridge/dw-hdmi.h >> > @@ -478,51 +478,6 @@ >> > #define HDMI_A_PRESETUP 0x501A >> > #define HDMI_A_SRM_BASE 0x5020 >> > >> > -/* CEC Engine Registers */ >> > -#define HDMI_CEC_CTRL 0x7D00 >> > -#define HDMI_CEC_STAT 0x7D01 >> > -#define HDMI_CEC_MASK 0x7D02 >> I don't know if this is relevant for a submission, but the build stops >> working here because of a missing definition HDMI_CEC_MASK >> Perhaps this should be inverted with 3/5 to make bissecting easier? >> I was trying to bissect a kernel panic, and I had to fix this by hand > > Doesn't make sense - patch 3 doesn't reference HDMI_CEC_MASK. > > Please show the build error in full. The build is actually fixed with patch 4. Building after patch 2 fails with: drivers/gpu/drm/bridge/dw-hdmi.c: In function ‘initialize_hdmi_ih_mutes’: drivers/gpu/drm/bridge/dw-hdmi.c:1300:26: error: ‘HDMI_CEC_MASK’ undeclared (first use in this function) hdmi_writeb(hdmi, 0xff, HDMI_CEC_MASK); The point of switching patch 3 and patch 2, is that the build works with patch 1,3 applied. Applying patch 2 breaks the build, but doesn't change any active code, so it's ok. So with the order 1,3,2,4,5, the build is broken only after 2, while with 1,2,3,4,5, it is broken after 2 and 3. I hope this makes my remark more explicit. If it doesn't, I think it is quite safe to just ignore it -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
