On Thu, Nov 10, 2016 at 4:02 AM, Andi Shyti <andi.shyti@xxxxxxxxxxx> wrote: > Hi Jacek, > >> > > > > Only DT bindings of LED class drivers should be placed in >> > > > > Documentation/devicetree/bindings/leds. Please move it to the >> > > > > media bindings. >> > > > >> > > > that's where I placed it first, but Rob asked me to put it in the >> > > > LED directory and Cc the LED mailining list. >> > > > >> > > > That's the discussion of the version 2: >> > > > >> > > > https://lkml.org/lkml/2016/9/12/380 >> > > > >> > > > Rob, Jacek, could you please agree where I can put the binding? >> > > >> > > I'm not sure if this is a good approach. I've noticed also that >> > > backlight bindings have been moved to leds, whereas they don't look >> > > similarly. >> > > >> > > We have common.txt LED bindings, that all LED class drivers' bindings >> > > have to follow. Neither backlight bindings nor these ones do that, >> > > which introduces some mess. >> > >> > And there are probably LED bindings that don't follow common.txt either. >> > >> > > Eventually adding a sub-directory, e.g. remote_control could make it >> > > somehow logically justified, but still - shouldn't bindings be >> > > placed in the documentation directory related to the subsystem of the >> > > driver they are predestined to? >> > >> > No. While binding directories often mirror the driver directories, they >> > are not the same. Bindings are grouped by types of h/w and IR LEDs are a >> > type of LED. >> > >> > If you prefer a sub-dir, that is fine with me. >> >> Fine. So how about sub-dir "ir" ? > > would we put here all the remote control bindings that currently > are under media? No. Only if they are just an LED that happens to be IR. Rob -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
