Hello Marek, On 11/09/2016 11:29 AM, Marek Szyprowski wrote: > This patch add support for Exynos5433 specific version of GScaller module. s/GScaller/GScaler > The main difference is between Exynos 5433 and earlier is addition of > new clocks that have to be controlled. > > Signed-off-by: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx> > --- > .../devicetree/bindings/media/exynos5-gsc.txt | 3 +- > drivers/media/platform/exynos-gsc/gsc-core.c | 74 ++++++++++++++++------ > drivers/media/platform/exynos-gsc/gsc-core.h | 6 +- > 3 files changed, 62 insertions(+), 21 deletions(-) > > diff --git a/Documentation/devicetree/bindings/media/exynos5-gsc.txt b/Documentation/devicetree/bindings/media/exynos5-gsc.txt Usually the DT changes go in a separate patch as documented in Documentation/devicetree/bindings/submitting-patches.txt. But I guess this is a too small change so is OK to squash it? > index 5fe9372..26ca25b 100644 > --- a/Documentation/devicetree/bindings/media/exynos5-gsc.txt > +++ b/Documentation/devicetree/bindings/media/exynos5-gsc.txt > @@ -3,7 +3,8 @@ > G-Scaler is used for scaling and color space conversion on EXYNOS5 SoCs. > > Required properties: > -- compatible: should be "samsung,exynos5-gsc" > +- compatible: should be "samsung,exynos5-gsc" (for Exynos 5250, 5420 and > + 5422 SoCs) or "samsung,exynos5433-gsc" (Exynos 5433) I would also add 5800 to the list. Besides these minor comments, the patch looks good to me: Reviewed-by: Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx> And I've also tested in an Exynos5800 Peach Pi Chromebook: Tested-by: Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx> Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
