Dear Matthias, Thank you for your review.I will include your advice in patch v5. On Mon, 2016-11-07 at 18:00 +0100, Matthias Brugger wrote: > > On 07/11/16 07:57, Rick Chang wrote: > > Add a DT binding documentation for Mediatek JPEG Decoder of > > MT2701 SoC. > > > > Signed-off-by: Rick Chang <rick.chang@xxxxxxxxxxxx> > > Signed-off-by: Minghsiu Tsai <minghsiu.tsai@xxxxxxxxxxxx> > > --- > > .../bindings/media/mediatek-jpeg-codec.txt | 35 ++++++++++++++++++++++ > > 1 file changed, 35 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/media/mediatek-jpeg-codec.txt > > > > diff --git a/Documentation/devicetree/bindings/media/mediatek-jpeg-codec.txt b/Documentation/devicetree/bindings/media/mediatek-jpeg-codec.txt > > new file mode 100644 > > index 0000000..c7dbcc2 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/media/mediatek-jpeg-codec.txt > > @@ -0,0 +1,35 @@ > > +* Mediatek JPEG Decoder > > + > > +Mediatek JPEG Decoder is the JPEG decode hardware present in Mediatek SoCs > > + > > +Required properties: > > +- compatible : "mediatek,jpgdec" > > Is this block in all arm SoCs from Mediatek? JPEG Decoder hardware is in most of Mediatek SoCs, but I can't guarantee that each of them has identical IP. > If not, then I would prefer to use "mediatek,mtXXXX-jpgdec" > where XXXX stands for the oldest model which has this block. > > In parallel to that the dts should have this compatible plus the one for > mt2701, for example: > compatible = "mediatek,mt2701-uart", "mediatek,mt6577-uart" The oldest model that I can make sure this patch series work on is mt8173.I will add it to the compatible string. > Thanks, > Matthias -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
