I've applied this patch to my smatch. Thanks for looking into this. Regards, Hans On 10/24/2016 10:21 PM, Mauro Carvalho Chehab wrote: > Em Mon, 24 Oct 2016 06:03:16 +0200 > "Hans Verkuil" <hverkuil@xxxxxxxxx> escreveu: > >> This message is generated daily by a cron job that builds media_tree for >> the kernels and architectures in the list below. >> >> Results of the daily build of media_tree: > > ... > >> sparse: WARNINGS >> >> Detailed results are available here: >> >> http://www.xs4all.nl/~hverkuil/logs/Monday.log > > I'm noticing that you're getting lots of warnings like this one: > > /home/hans/work/build/media-git/drivers/media/pci/bt8xx/bttv-driver.c:3847 bttv_irq() warn: invalid KERN_* level: KERN_SOH_ASCII followed by '\x63' > > This warning is bogus, and it is result of a new implementation for > KERN_CONT. > > Please apply the following patch to get rid of that on the daily builds. > > Dan, > > Could you also apply it (or some variant of it upstream), to avoid us > the need of carry on this patch on our git trees? > > Thanks, > Mauro > > check_kernel_printf: Ignore the new "continue" level > > [PATCH] Suppress warnings like this one: > drivers/media/rc/imon.c:1879 imon_get_ffdc_type() warn: invalid KERN_* level: KERN_SOH_ASCII followed by '\x63' > > Signed-off-by: Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxxxxx> > > diff --git a/check_kernel_printf.c b/check_kernel_printf.c > index d0ca89e5bd61..a7ae4f2e1588 100644 > --- a/check_kernel_printf.c > +++ b/check_kernel_printf.c > @@ -807,10 +807,12 @@ check_format_string(const char *fmt, const char *caller) > * "%c...". printk explicitly supports > * this. > */ > + if (f[1] == 'c') > + break; > if (!(('0' <= f[1] && f[1] <= '7') || > f[1] == 'd' || > (f[1] == '%' && f[2] == 'c'))) > - sm_msg("warn: invalid KERN_* level: KERN_SOH_ASCII followed by '\\x%02x'", (unsigned char)f[1]); > + sm_msg("warn: invalid KERN_* level: KERN_SOH_ASCII followed by 0x%02x ('%c')", (unsigned char)f[1], f[1]); > break; > case '\t': > case '\n': > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
