Em Wed, 19 Oct 2016 09:56:25 +0200
Stefan Richter <stefanr@xxxxxxxxxxxxxxxxx> escreveu:
> On Oct 19 Takashi Sakamoto wrote:
> > --- a/drivers/media/firewire/firedtv-rc.c
> > +++ b/drivers/media/firewire/firedtv-rc.c
> > @@ -184,8 +184,9 @@ void fdtv_handle_rc(struct firedtv *fdtv, unsigned
> > int code)
> > else if (code >= 0x4540 && code <= 0x4542)
> > code = oldtable[code - 0x4521];
> > else {
> > - printk(KERN_DEBUG "firedtv: invalid key code 0x%04x "
> > - "from remote control\n", code);
> > + dev_dbg(fdtv->device,
> > + "invalid key code 0x%04x from remote control\n",
> > + code);
> > return;
> > }
> >
>
> Yes, dev_XYZ(fdtv->device, ...) is better here and is already used this
> way throughout the firedtv driver. firedtv-rc.c somehow fell through the
> cracks when firedtv was made to use dev_XYZ().
>
> (On an unrelated note, this reminds me that I still need to take care of
> Mauro's patches "Add a keymap for FireDTV board" and "firedtv: Port it to
> use rc_core" from May 28, 2012.)
Oh! I forgot about those a long time ago ;) Yeah, it would be great if
you could look into those patches when you have some time.
Thanks,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
