Hi Steve, On Monday 17 Oct 2016 15:36:14 Steve Longerbeam wrote: > On 10/16/2016 05:18 AM, Laurent Pinchart wrote: > > On Wednesday 03 Aug 2016 11:03:45 Steve Longerbeam wrote: > >> Parse the optional v4l2 endpoint DT node. If the bus type is > >> V4L2_MBUS_BT656 and the endpoint node specifies "newavmode", > >> configure the BT.656 bus in NEWAVMODE. > >> > >> Signed-off-by: Steve Longerbeam <steve_longerbeam@xxxxxxxxxx> > >> --- > >> v4: no changes > >> v3: > >> - the newavmode endpoint property is now private to adv7180. > >> --- > >> .../devicetree/bindings/media/i2c/adv7180.txt | 4 ++ > >> drivers/media/i2c/adv7180.c | 46 ++++++++++++++-- > >> 2 files changed, 47 insertions(+), 3 deletions(-) > >> > >> diff --git a/Documentation/devicetree/bindings/media/i2c/adv7180.txt > >> b/Documentation/devicetree/bindings/media/i2c/adv7180.txt index > >> 0d50115..6c175d2 100644 > >> --- a/Documentation/devicetree/bindings/media/i2c/adv7180.txt > >> +++ b/Documentation/devicetree/bindings/media/i2c/adv7180.txt > >> @@ -15,6 +15,10 @@ Required Properties : > >> "adi,adv7282" > >> "adi,adv7282-m" > >> > >> +Optional Endpoint Properties : > >> +- newavmode: a boolean property to indicate the BT.656 bus is operating > >> + in Analog Device's NEWAVMODE. Valid for BT.656 busses only. > > > > This is a vendor-specific property, it should be prefixed with "adi,". > > Ok, I'll do that in next version. > > > Could > > > > you also explain how this mode works ? I'd like to make sure it qualifies > > for a DT property. > > The blurb in the ADV718x manual is terse: > > "When NEWAVMODE is 0 (enabled), EAV/SAV codes are generated to > suit Analog Devices encoders. No adjustments are possible." > > "Setting NEWAVMODE to 1 (default) enables the manual position > of the VSYNC, FIELD, and AV codes using Register 0x32 to > Register 0x33 and Register 0xE5 to Register 0xEA. Default register > settings are CCIR656 compliant;" > > So it's not clear to me how the generated EAV and SAV codes are > different from standard CCIR656, but apparently they are. Shouldn't we understand how it works to create proper DT bindings ? :-) -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
