Re: [PATCH 00/57] don't break long lines on strings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Em Sat, 15 Oct 2016 15:46:14 +0200
Stefan Richter <stefanr@xxxxxxxxxxxxxxxxx> escreveu:

> On Oct 14 Mauro Carvalho Chehab wrote:
> > There are lots of drivers on media that breaks long line strings in order to
> > fit into 80 columns. This was an usual practice to make checkpatch happy.  
> 
> This was practice even before checkpatch existed.

True, but before checkpatch, we didn't care much to enforce breaking
long string lines, letting up to the patch author to decide. As far
as I remember, on media subsystem, only a handful drivers were actually
breaking long strings (or even respecting the 80 cols limit). 

After checkpatch, we started to enforce such practice, until some discussions 
on LKML arguing that breaking long strings actually make more harm than good,
as it makes harder to use grep to identify what part of the Kernel produced
a certain log message.

Thanks,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux