On Sat, 3 Oct 2009 01:27:04 +0200 (CEST) Guennadi Liakhovetski <g.liakhovetski@xxxxxx> wrote: > On Fri, 2 Oct 2009, Antonio Ospite wrote: > > > Hi, > > > > after updating to 2.6.32-rc2 I can't capture anymore with the setup in the > > subject. > > Indeed:-( Please, verify, that this patch fixes your problem (completely > untested), if it does, I'll push it for 2.6.32: > > pxa_camera: fix camera pixel format configuration > > A typo prevents correct picel format negotiation with client drivers. > typo in the log message too :) s/picel/pixel/ > Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@xxxxxx> > --- > diff --git a/drivers/media/video/pxa_camera.c b/drivers/media/video/pxa_camera.c > index 6952e96..aa831d5 100644 > --- a/drivers/media/video/pxa_camera.c > +++ b/drivers/media/video/pxa_camera.c > @@ -1432,7 +1432,9 @@ static int pxa_camera_set_fmt(struct soc_camera_device *icd, > icd->sense = &sense; > > cam_f.fmt.pix.pixelformat = cam_fmt->fourcc; > - ret = v4l2_subdev_call(sd, video, s_fmt, f); > + ret = v4l2_subdev_call(sd, video, s_fmt, &cam_f); > + cam_f.fmt.pix.pixelformat = pix->pixelformat; > + *pix = cam_f.fmt.pix; > > icd->sense = NULL; Ok, I can capture again even by only fixing the typo: s/f/&cam_f/ but I don't know if this is complete. Anyways your patch works, but the picture is now shifted, see: http://people.openezx.org/ao2/a780-pxa-camera-mt9m111-shifted.jpg Is this because of the new cropping code? Thanks, Antonio -- Antonio Ospite http://ao2.it PGP public key ID: 0x4553B001 A: Because it messes up the order in which people normally read text. See http://en.wikipedia.org/wiki/Posting_style Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail?
Attachment:
pgpeu6riUrtzl.pgp
Description: PGP signature
