From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> Date: Thu, 13 Oct 2016 18:06:18 +0200 Several update suggestions were taken into account from static source code analysis. Markus Elfring (18): Use kcalloc() in two functions Move two assignments in redrat3_transmit_ir() Return directly after a failed kcalloc() in redrat3_transmit_ir() One function call less in redrat3_transmit_ir() after error detection Delete six messages for a failed memory allocation Delete an unnecessary variable initialisation in redrat3_get_firmware_rev() Improve another size determination in redrat3_reset() Improve another size determination in redrat3_send_cmd() Move a variable assignment in redrat3_dev_probe() Delete an unnecessary variable initialisation in redrat3_init_rc_dev() Delete the variable "dev" in redrat3_init_rc_dev() Move a variable assignment in redrat3_init_rc_dev() Return directly after a failed rc_allocate_device() in redrat3_init_rc_dev() Rename a jump label in redrat3_init_rc_dev() Delete two variables in redrat3_set_timeout() Move a variable assignment in redrat3_set_timeout() Adjust two checks for null pointers in redrat3_dev_probe() Combine substrings for six messages drivers/media/rc/redrat3.c | 146 +++++++++++++++++++++------------------------ 1 file changed, 67 insertions(+), 79 deletions(-) -- 2.10.1 -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html