Em Tue, 11 Oct 2016 23:41:53 +0200 (CEST) Julia Lawall <julia.lawall@xxxxxxx> escreveu: > On Tue, 11 Oct 2016, Mauro Carvalho Chehab wrote: > > > Em Tue, 11 Oct 2016 15:16:24 +0200 (CEST) > > Julia Lawall <julia.lawall@xxxxxxx> escreveu: > > > > > On Tue, 11 Oct 2016, Julia Lawall wrote: > > > > > > > It looks like a lock may be needed before line 174. > > > > > > Sorry, an unlock. > > > > I suspect that this is a false positive warning, as there is a > > mutex unlock on the same routine, at line 203. All exit > > conditions go to the unlock condition. > > There is a direct exit in line 174. Ah! I was looking at the wrong patch (cinergyT2-core: don't do DMA on stack). Thanks for pointing it. I'll the affected code to: - dvb_usb_generic_rw(d, st->data, 1, st->data, 5, 0); + ret = dvb_usb_generic_rw(d, st->data, 1, st->data, 5, 0); + if (ret < 0) + goto ret; Regards, Mauro -- Thanks, Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
