[linux-review:Mauro-Carvalho-Chehab/Don-t-use-stack-for-DMA-transers-on-dvb-usb-drivers/20161008-021635 21/26] drivers/media/usb/dvb-usb/pctv452e.c:113:26: error: expected expression before '||' token

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



tree:   https://github.com/0day-ci/linux Mauro-Carvalho-Chehab/Don-t-use-stack-for-DMA-transers-on-dvb-usb-drivers/20161008-021635
head:   01e4e9b657c0de0c857817353b4ffbb3da5b9cb3
commit: 71eb7f5998d859d9de08128ebd4f3187b5f9fcbf [21/26] pctv452e: don't call BUG_ON() on non-fatal error
config: x86_64-rhel (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        git checkout 71eb7f5998d859d9de08128ebd4f3187b5f9fcbf
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All error/warnings (new ones prefixed by >>):

   drivers/media/usb/dvb-usb/pctv452e.c: In function 'tt3650_ci_msg':
>> drivers/media/usb/dvb-usb/pctv452e.c:112:19: warning: suggest parentheses around '&&' within '||' [-Wparentheses]
     if (NULL == data && 0 != (write_len | read_len) ||
                       
>> drivers/media/usb/dvb-usb/pctv452e.c:113:26: error: expected expression before '||' token
         write_len > 64 - 4) || (read_len > 64 - 4)) {
                             ^~
   drivers/media/usb/dvb-usb/pctv452e.c:112:2: warning: this 'if' clause does not guard... [-Wmisleading-indentation]
     if (NULL == data && 0 != (write_len | read_len) ||
     ^~
   drivers/media/usb/dvb-usb/pctv452e.c:113:48: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'if'
         write_len > 64 - 4) || (read_len > 64 - 4)) {
                                                   ^
>> drivers/media/usb/dvb-usb/pctv452e.c:113:48: error: expected statement before ')' token

vim +113 drivers/media/usb/dvb-usb/pctv452e.c

   106	{
   107		struct pctv452e_state *state = (struct pctv452e_state *)d->priv;
   108		u8 id;
   109		unsigned int rlen;
   110		int ret;
   111	
 > 112		if (NULL == data && 0 != (write_len | read_len) ||
 > 113		    write_len > 64 - 4) || (read_len > 64 - 4)) {
   114			ret = -EIO;
   115			goto failed;
   116		};

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux