Hi, On 09/19/2016 01:12 PM, Hans Verkuil wrote: > On 09/07/2016 01:37 PM, Stanimir Varbanov wrote: >> This consists of video decoder implementation plus decoder >> controls. >> >> Signed-off-by: Stanimir Varbanov <stanimir.varbanov@xxxxxxxxxx> >> --- >> drivers/media/platform/qcom/vidc/vdec.c | 1091 +++++++++++++++++++++++++ >> drivers/media/platform/qcom/vidc/vdec.h | 29 + >> drivers/media/platform/qcom/vidc/vdec_ctrls.c | 200 +++++ >> drivers/media/platform/qcom/vidc/vdec_ctrls.h | 21 + >> 4 files changed, 1341 insertions(+) >> create mode 100644 drivers/media/platform/qcom/vidc/vdec.c >> create mode 100644 drivers/media/platform/qcom/vidc/vdec.h >> create mode 100644 drivers/media/platform/qcom/vidc/vdec_ctrls.c >> create mode 100644 drivers/media/platform/qcom/vidc/vdec_ctrls.h >> > > <snip> > >> +static int vdec_event_notify(struct hfi_inst *hfi_inst, u32 event, >> + struct hfi_event_data *data) >> +{ >> + struct vidc_inst *inst = hfi_inst->ops_priv; >> + struct device *dev = inst->core->dev; >> + const struct v4l2_event ev = { .type = V4L2_EVENT_SOURCE_CHANGE }; > > 1) this can be static > 2) set the u.src_change.changes as well. Sure will do. -- regards, Stan -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html