On Fri, Sep 02, 2016 at 02:33:20PM +0900, Andi Shyti wrote: > Hi Rob, > > > > Document the ir-spi driver's binding which is a IR led driven > > > through the SPI line. > > > > > > Signed-off-by: Andi Shyti <andi.shyti@xxxxxxxxxxx> > > > --- > > > Documentation/devicetree/bindings/media/spi-ir.txt | 26 ++++++++++++++++++++++ > > > 1 file changed, 26 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/media/spi-ir.txt > > > > > > diff --git a/Documentation/devicetree/bindings/media/spi-ir.txt b/Documentation/devicetree/bindings/media/spi-ir.txt > > > new file mode 100644 > > > index 0000000..85cb21b > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/media/spi-ir.txt > > > > Move this to bindings/leds, and CC the leds maintainers. > > More than an LED this is the driver of a remote controller, the > driver itself is under drivers/media/rc/. The hardware is just an LED though and bindings describe h/w. What you are using it for doesn't really matter. You only need to know it's an IR led. > Besides all the transmitters have an LED but still they are media > devices. This is a bit special because it's so simple that the > only hardware left is the LED itself, but still it's a media remote > controller. > > > > @@ -0,0 +1,26 @@ > > > +Device tree bindings for IR LED connected through SPI bus which is used as > > > +remote controller. > > > + > > > +The IR LED switch is connected to the MOSI line of the SPI device and the data > > > +are delivered thourgh that. > > > + > > > +Required properties: > > > + - compatible: should be "ir-spi". > > > > Really this is just an LED connected to a SPI, so maybe this should > > just be "spi-led". If being more specific is helpful, then I'm all for > > that, but perhaps spi-ir-led. (Trying to be consistent in naming with > > gpio-leds). > > As I mentioned above, all transmitters have an LED, but they do > not have the 'led' name. "ir-spi" is coherent with the device > driver name and the driver name is coherent with the media/rc > driver's naming. The driver name is irrelevant to the binding. [...] > If it's OK for you, I would keep the name and documentation path > and fix the rest. Please let me know if I'm missing something :) It's not OK for me. Rob -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
