Re: [PATCH v2] V4L2: Add documentation for SDI timings and related flags

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Le 12/08/2016 à 15:17, Hans Verkuil a écrit :
> On 08/04/2016 05:39 PM, Charles-Antoine Couret wrote:
> 
> A commit log is missing here.

Yeah I will fix that.

>> diff --git a/Documentation/media/uapi/v4l/vidioc-g-dv-timings.rst b/Documentation/media/uapi/v4l/vidioc-g-dv-timings.rst
>> index f7bf21f..0205bf6 100644
>> --- a/Documentation/media/uapi/v4l/vidioc-g-dv-timings.rst
>> +++ b/Documentation/media/uapi/v4l/vidioc-g-dv-timings.rst
>> @@ -339,6 +339,14 @@ EBUSY
>>  
>>         -  The timings follow the VESA Generalized Timings Formula standard
>>  
>> +    -  .. row 7
>> +
>> +       -  ``V4L2_DV_BT_STD_SDI``
>> +
>> +       -  The timings follow the SDI Timings standard.
>> +	  There are not always horizontal syncs/porches or similar in this format.
>> +	  If it is not precised by standard, blanking timings must be set in
>> +	  hsync or vsync fields by default.
> 
> OK. This is confusing. The text was changed after my question about something porch-like
> in the SMPTE-125M standard. But I see nothing like that after re-reading it.
> 
> So what sort of 'porch' timing were you thinking of?

In SMPTE-125M for example, the time between the real horizontal blanking is precised (16 pixelclock).
For me it looks like front porch timing.
 
> I wonder if I shouldn't just use the text from your first patch:
> 
>        -  ``V4L2_DV_BT_STD_SDI``
> 
>        -  The timings follow the SDI Timings standard.
> 	  There are no horizontal syncs/porches at all in this format.
> 	  Total blanking timings must be set in hsync or vsync fields only.

I agree with that if you prefer, after all the front/backporch are probably irrelevant in this case.
So, if you confirm this way, I would send you another patchset to fix that.

Thank you.
Regards,
Charles-Antoine Couret
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux