Hi Hans, On Mon, 2016-09-05 at 13:26 +0200, Hans Verkuil wrote: > On 09/05/2016 12:52 PM, Tiffany Lin wrote: > > Hi Hans, > > > > On Mon, 2016-09-05 at 12:09 +0200, Hans Verkuil wrote: > >> On 09/05/2016 11:53 AM, Hans Verkuil wrote: > >>> On 09/05/2016 11:50 AM, Tiffany Lin wrote: > >>>> Hi Hans, > >>>> > >>>> On Mon, 2016-09-05 at 11:33 +0200, Hans Verkuil wrote: > >>>>> On 09/02/2016 02:19 PM, Tiffany Lin wrote: > >>>>>> ============== > >>>>>> Introduction > >>>>>> ============== > >>>>>> > >>>>>> The purpose of this series is to add the driver for video codec hw embedded in the Mediatek's MT8173 SoCs. > >>>>>> Mediatek Video Codec is able to handle video decoding and encoding of in a range of formats. > >>>>>> > >>>>>> This patch series rely on MTK VPU driver that have been merged in v4.8-rc1. > >>>>>> Mediatek Video Decoder driver rely on VPU driver to load, communicate with VPU. > >>>>>> > >>>>>> Internally the driver uses videobuf2 framework, and MTK IOMMU and MTK SMI both have been merged in v4.6-rc1. > >>>>>> > >>>>>> [1]https://chromium-review.googlesource.com/#/c/245241/ > >>>>> > >>>>> This patch series fails to apply to the media_tree master (patch 3/9). Can you rebase and repost? > >>>>> > >>>>> I'm ready to make a pull request for this, so I hope you can fix this soon. > >>>>> > >>>> I saw Encoder fix patches in fixes branch. > >>>> This patch series is base on Encoder fix patches. > >>>> > >>>> [media] vcodec:mediatek: Refine VP8 encoder driver > >>>> [media] vcodec:mediatek: Refine H264 encoder driver > >>>> [media] vcodec:mediatek: change H264 profile default to profile high > >>>> [media] vcodec:mediatek: Add timestamp and timecode copy for V4L2 > >>>> Encoder > >>>> [media] vcodec:mediatek: Fix visible_height larger than coded_height > >>>> issue in s_fmt_out > >>>> [media] vcodec:mediatek: Fix fops_vcodec_release flow for V4L2 Encoder > >>>> [media] vcodec:mediatek:code refine for v4l2 Encoder driver > >>>> [media] dvb_frontend: Use memdup_user() rather than duplicating its > >>>> implementation > >>>> > >>>> > >>>> If I do not rebase decoder patch series base on Encoder fix pathces. > >>>> Then it will fail after Encoder fix patches merged. > >>>> > >>>> May I know what parent patch I need to rebase to to fix this issue? > >>> > >>> Ah, OK. I will retest placing this on top of those fixes. I forgot about the > >>> pending fixes. I'll handle this. > >> > >> OK, that works much better when it is on top of the fixes. > >> > >> Only one thing is missing: an entry in the MAINTAINERS file. Strange that that > >> wasn't done for the encoder driver, we must have missed that. So can you make a > >> patch adding the en/decoder driver to this file? I'm ready to make the pull > >> request once I have that. > >> > > Got it. I will check and update it. > > > > I have a question about decoder device node. > > In v5 decoder patch series, I do not add device node patch at end of > > patch series. > > I plain to put it in MT21C format patch series, is it ok? > > What is the reason for not adding it in the decoder patch series? > It is because our decoder HW only support MT21C format. best regards, Tiffany > Regards, > > Hans -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
