On Mon 22 Aug 06:13 PDT 2016, Stanimir Varbanov wrote:
> Here is the implementation of Venus video accelerator low-level
> functionality. It contanins code which setup the registers and
> startup uthe processor, allocate and manipulates with the shared
> memory used for sending commands and receiving messages.
>
> Signed-off-by: Stanimir Varbanov <stanimir.varbanov@xxxxxxxxxx>
> ---
> drivers/media/platform/qcom/vidc/hfi_venus.c | 1539 +++++++++++++++++++++++
> drivers/media/platform/qcom/vidc/hfi_venus.h | 25 +
> drivers/media/platform/qcom/vidc/hfi_venus_io.h | 98 ++
> 3 files changed, 1662 insertions(+)
> create mode 100644 drivers/media/platform/qcom/vidc/hfi_venus.c
> create mode 100644 drivers/media/platform/qcom/vidc/hfi_venus.h
> create mode 100644 drivers/media/platform/qcom/vidc/hfi_venus_io.h
>
> diff --git a/drivers/media/platform/qcom/vidc/hfi_venus.c b/drivers/media/platform/qcom/vidc/hfi_venus.c
[..]
> +
> +static const struct hfi_ops venus_hfi_ops = {
> + .core_init = venus_hfi_core_init,
> + .core_deinit = venus_hfi_core_deinit,
> + .core_ping = venus_hfi_core_ping,
> + .core_trigger_ssr = venus_hfi_core_trigger_ssr,
> +
> + .session_init = venus_hfi_session_init,
> + .session_end = venus_hfi_session_end,
> + .session_abort = venus_hfi_session_abort,
> + .session_flush = venus_hfi_session_flush,
> + .session_start = venus_hfi_session_start,
> + .session_stop = venus_hfi_session_stop,
> + .session_etb = venus_hfi_session_etb,
> + .session_ftb = venus_hfi_session_ftb,
> + .session_set_buffers = venus_hfi_session_set_buffers,
> + .session_release_buffers = venus_hfi_session_release_buffers,
> + .session_load_res = venus_hfi_session_load_res,
> + .session_release_res = venus_hfi_session_release_res,
> + .session_parse_seq_hdr = venus_hfi_session_parse_seq_hdr,
> + .session_get_seq_hdr = venus_hfi_session_get_seq_hdr,
> + .session_set_property = venus_hfi_session_set_property,
> + .session_get_property = venus_hfi_session_get_property,
> +
> + .resume = venus_hfi_resume,
> + .suspend = venus_hfi_suspend,
> +
> + .isr = venus_isr,
> + .isr_thread = venus_isr_thread,
> +};
> +
> +void venus_hfi_destroy(struct hfi_core *hfi)
> +{
> + struct venus_hfi_device *hdev = to_hfi_priv(hfi);
> +
> + venus_interface_queues_release(hdev);
> + mutex_destroy(&hdev->lock);
> + kfree(hdev);
> +}
> +
> +int venus_hfi_create(struct hfi_core *hfi, const struct vidc_resources *res,
> + void __iomem *base)
> +{
Rather than having the core figure out which *_hfi_create() to call I
think this should be the probe() entry point, calling into the core
registering the venus_hfi_ops - a common-probe() in the hfi/vidc core
could still do most of the heavy lifting.
Probing the driver up from the transport rather than for the highest
logical layer allows us to inject a separate hfi_ops for the apr tal
case.
> + struct venus_hfi_device *hdev;
> + int ret;
> +
> + hdev = kzalloc(sizeof(*hdev), GFP_KERNEL);
> + if (!hdev)
> + return -ENOMEM;
> +
> + mutex_init(&hdev->lock);
> +
> + hdev->res = res;
> + hdev->pkt_ops = hfi->pkt_ops;
> + hdev->packetization_type = HFI_PACKETIZATION_LEGACY;
> + hdev->base = base;
> + hdev->dev = hfi->dev;
> + hdev->suspended = true;
> +
> + hfi->priv = hdev;
> + hfi->ops = &venus_hfi_ops;
> + hfi->core_caps = VIDC_ENC_ROTATION_CAPABILITY |
> + VIDC_ENC_SCALING_CAPABILITY |
> + VIDC_ENC_DEINTERLACE_CAPABILITY |
> + VIDC_DEC_MULTI_STREAM_CAPABILITY;
> +
> + ret = venus_interface_queues_init(hdev);
> + if (ret)
> + goto err_kfree;
> +
> + return 0;
> +
> +err_kfree:
> + kfree(hdev);
> + hfi->priv = NULL;
> + hfi->ops = NULL;
> + return ret;
> +}
I'll try to find some time to do a more detailed review of the
implementation.
Regards,
Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
