Hi Hans, On Mon, Aug 22, 2016 at 02:24:59PM +0200, Hans Verkuil wrote: > On 08/19/2016 12:23 PM, Sakari Ailus wrote: > > The release callback may be used by the driver to signal the release of > > the media device. This makes it possible to embed a driver private struct > > to the same memory allocation. > > This is a bit weird: you either add support for private data with a priv > pointer as in the previous patch, or you allow for larger structs. > > Doing both doesn't seem right. In both cases you want the release callback, > so that's fine. But I think you should pick which method you want to keep > private data around. > > I have a slight preference for a priv pointer, but I'm OK with either solution. I'll drop the size parameter in the next version. -- Sakari Ailus e-mail: sakari.ailus@xxxxxx XMPP: sailus@xxxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
