Hi Hans,
Thank you for the patch.
On Wednesday 17 Aug 2016 08:29:38 Hans Verkuil wrote:
> From: Hans Verkuil <hans.verkuil@xxxxxxxxx>
>
> Add v4l2-async support for this driver.
>
> Signed-off-by: Hans Verkuil <hans.verkuil@xxxxxxxxx>
> ---
> drivers/media/i2c/ov7670.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/media/i2c/ov7670.c b/drivers/media/i2c/ov7670.c
> index 25f46c7..26ad1a2 100644
> --- a/drivers/media/i2c/ov7670.c
> +++ b/drivers/media/i2c/ov7670.c
> @@ -1662,6 +1662,14 @@ static int ov7670_probe(struct i2c_client *client,
> v4l2_ctrl_cluster(2, &info->saturation);
> v4l2_ctrl_handler_setup(&info->hdl);
>
> + ret = v4l2_async_register_subdev(&info->sd);
> + if (ret < 0) {
> +#if defined(CONFIG_MEDIA_CONTROLLER)
> + media_entity_cleanup(&info->sd.entity);
> +#endif
Don't you need to also call v4l2_ctrl_handler_free() ?
> + return ret;
> + }
> +
> return 0;
> }
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
