Re: [PATCH 2/4] 18271_calc_main_pll small bugfix

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Sep 22, 2009 at 5:06 PM,  <spam@xxxxxxxxxxxxxxxxx> wrote:
>
> Removed code fragment that is not part of the (C2) specs. Possibly an early
> remnant of an attempted if_notch filter configuration. It is already
> handled correctly in the tda18271_set_if_notch function.
>
> Signed-off-by: Henk.Vergonet@xxxxxxxxx
>
> diff -r 29e4ba1a09bc linux/drivers/media/common/tuners/tda18271-common.c
> --- a/linux/drivers/media/common/tuners/tda18271-common.c       Sat Sep 19 09:45:22 2009 -0300
> +++ b/linux/drivers/media/common/tuners/tda18271-common.c       Tue Sep 22 22:06:31 2009 +0200
> @@ -582,15 +582,6 @@
>
>        regs[R_MPD]   = (0x77 & pd);
>
> -       switch (priv->mode) {
> -       case TDA18271_ANALOG:
> -               regs[R_MPD]  &= ~0x08;
> -               break;
> -       case TDA18271_DIGITAL:
> -               regs[R_MPD]  |=  0x08;
> -               break;
> -       }
> -
>        div =  ((d * (freq / 1000)) << 7) / 125;
>
>        regs[R_MD1]   = 0x7f & (div >> 16);
>


NACK.  This bit needs to remain -- do not merge this.

Regards,

Mike Krufky
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux