Hans Verkuil <hverkuil@xxxxxxxxx> writes: > On 08/08/2016 09:30 PM, Robert Jarzmik wrote: > >> + pcdev->sensor = subdev; >> + pcdev->vdev.queue = &pcdev->vb2_vq; >> + pcdev->vdev.v4l2_dev = &pcdev->v4l2_dev; > > You're missing this line here: > > pcdev->vdev.ctrl_handler = subdev->ctrl_handler; > > This ensures that the sensor's controls are exposed to the video device node. Okay, I'm on it, for v4. >> + video_set_drvdata(&pcdev->vdev, pcdev); >> + >> + v4l2_disable_ioctl(vdev, VIDIOC_G_STD); >> + v4l2_disable_ioctl(vdev, VIDIOC_S_STD); > > Since you don't implement vidioc_g/s_std these two lines can be removed. Okay, for v4. Cheers. -- Robert -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
