> -----Original Message----- > From: Sebastian Andrzej Siewior [mailto:bigeasy@xxxxxxxxxxxxx] > Sent: Wednesday, September 23, 2009 12:04 AM > To: Mauro Carvalho Chehab > Cc: linux-media@xxxxxxxxxxxxxxx; Hiremath, Vaibhav; Roel Kluin > Subject: [PATCH] media/tvp514x: recognize the error case in > tvp514x_read_reg() > > From: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx> > > i2c_smbus_read_byte_data() returns a negative value on error. It is > very > likely to be != -1 (-EPERM). > > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx> > --- > Noticed by strange results during signal beeing pending. > > drivers/media/video/tvp514x.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/media/video/tvp514x.c > b/drivers/media/video/tvp514x.c > index 2443726..26b4e71 100644 > --- a/drivers/media/video/tvp514x.c > +++ b/drivers/media/video/tvp514x.c > @@ -272,7 +272,7 @@ static int tvp514x_read_reg(struct v4l2_subdev > *sd, u8 reg) > read_again: > > err = i2c_smbus_read_byte_data(client, reg); > - if (err == -1) { > + if (err < 0) { > if (retry <= I2C_RETRY_COUNT) { > v4l2_warn(sd, "Read: retry ... %d\n", retry); > retry++; [Hiremath, Vaibhav] Thanks Sebastian, good catch. Acked by Vaibhav Hiremath. Hans, can you apply this patch to your tree. Thanks, Vaibhav > -- > 1.6.3.3 > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
