> Sometimes it better to show more message - especially in error conditions :)
Sure, if they contain additional information.
> btw, do you make sanity check for "duplicate" log messages ?
I checked all error messages if they contain additional information.
> ret = i2c_add_adapter(&i2c->adap);
> - if (ret) {
> - dev_err(&ndev->pci_dev->dev,
> - "%s(): failed to add I2C adapter\n", __func__);
> + if (ret)
> return ret;
> - }
IMHO, this one doesn't. __func__ is not helpful to users. And the error
messages in the core will make sure that a developer knows where to
start looking.
Attachment:
signature.asc
Description: PGP signature
