I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu <chuansheng.liu@xxxxxxxxx> Signed-off-by: Baole Ni <baolex.ni@xxxxxxxxx> --- drivers/media/usb/tm6000/tm6000-video.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/usb/tm6000/tm6000-video.c b/drivers/media/usb/tm6000/tm6000-video.c index fa5e8bd..6a81a2e 100644 --- a/drivers/media/usb/tm6000/tm6000-video.c +++ b/drivers/media/usb/tm6000/tm6000-video.c @@ -1716,10 +1716,10 @@ int tm6000_v4l2_exit(void) module_param(video_nr, int, 0); MODULE_PARM_DESC(video_nr, "Allow changing video device number"); -module_param_named(debug, tm6000_debug, int, 0444); +module_param_named(debug, tm6000_debug, int, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(debug, "activates debug info"); -module_param(vid_limit, int, 0644); +module_param(vid_limit, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(vid_limit, "capture memory limit in megabytes"); module_param(keep_urb, bool, 0); -- 2.9.2 -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
