I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.
Signed-off-by: Chuansheng Liu <chuansheng.liu@xxxxxxxxx>
Signed-off-by: Baole Ni <baolex.ni@xxxxxxxxx>
---
drivers/media/usb/stkwebcam/stk-webcam.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/media/usb/stkwebcam/stk-webcam.c b/drivers/media/usb/stkwebcam/stk-webcam.c
index c21c4c0..ba716bd 100644
--- a/drivers/media/usb/stkwebcam/stk-webcam.c
+++ b/drivers/media/usb/stkwebcam/stk-webcam.c
@@ -41,15 +41,15 @@
static int hflip = -1;
-module_param(hflip, int, 0444);
+module_param(hflip, int, S_IRUSR | S_IRGRP | S_IROTH);
MODULE_PARM_DESC(hflip, "Horizontal image flip (mirror). Defaults to 0");
static int vflip = -1;
-module_param(vflip, int, 0444);
+module_param(vflip, int, S_IRUSR | S_IRGRP | S_IROTH);
MODULE_PARM_DESC(vflip, "Vertical image flip. Defaults to 0");
static int debug;
-module_param(debug, int, 0444);
+module_param(debug, int, S_IRUSR | S_IRGRP | S_IROTH);
MODULE_PARM_DESC(debug, "Debug v4l ioctls. Defaults to 0");
MODULE_LICENSE("GPL");
--
2.9.2
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
