I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu <chuansheng.liu@xxxxxxxxx> Signed-off-by: Baole Ni <baolex.ni@xxxxxxxxx> --- drivers/media/v4l2-core/tuner-core.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/media/v4l2-core/tuner-core.c b/drivers/media/v4l2-core/tuner-core.c index 731487b..2d029d2 100644 --- a/drivers/media/v4l2-core/tuner-core.c +++ b/drivers/media/v4l2-core/tuner-core.c @@ -54,9 +54,9 @@ static unsigned int addr; static unsigned int no_autodetect; static unsigned int show_i2c; -module_param(addr, int, 0444); -module_param(no_autodetect, int, 0444); -module_param(show_i2c, int, 0444); +module_param(addr, int, S_IRUSR | S_IRGRP | S_IROTH); +module_param(no_autodetect, int, S_IRUSR | S_IRGRP | S_IROTH); +module_param(show_i2c, int, S_IRUSR | S_IRGRP | S_IROTH); /* insmod options used at runtime => read/write */ static int tuner_debug; @@ -66,12 +66,12 @@ static char pal[] = "--"; static char secam[] = "--"; static char ntsc[] = "-"; -module_param_named(debug, tuner_debug, int, 0644); -module_param_array(tv_range, int, NULL, 0644); -module_param_array(radio_range, int, NULL, 0644); -module_param_string(pal, pal, sizeof(pal), 0644); -module_param_string(secam, secam, sizeof(secam), 0644); -module_param_string(ntsc, ntsc, sizeof(ntsc), 0644); +module_param_named(debug, tuner_debug, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); +module_param_array(tv_range, int, NULL, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); +module_param_array(radio_range, int, NULL, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); +module_param_string(pal, pal, sizeof(pal), S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); +module_param_string(secam, secam, sizeof(secam), S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); +module_param_string(ntsc, ntsc, sizeof(ntsc), S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); /* * Static vars -- 2.9.2 -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
