[PATCH v3 0/5] Refactor media IOCTL handling, add variable length arguments

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

This is the third version of the media IOCTL handling rework set. What's
changed since v2:

patch 3:

- Remove function to calculate maximum argument size, replace by a char         
  array of 256 or kmalloc() if that's too small.                                

- info->arg_from_user() may fail. Check the return code.                        

- Instead of providing a no-operation of a copy function, check whether one is  
  defined. If not, don't call one.                                              

patch 4:

- Arrange the flags field next to cmd, which is an integer. This avoids         
  creating extra holes in the struct memory layout.                             

patch 5:

- Use a list of supported argument sizes instead of a minimum value.

---

The patches themselves have been reworked so I don't detail the changes         
in this set. What's noteworthy however is that the set adds support for         
variable length IOCTL arguments.                                                
                                                                                
(The motivation for these patches is having found myself pondering whether      
to have nine or thirteen reserved fields for the request IOCTL. I decided       
to address the problem instead. If this is found workable on the media          
controller we could follow the same model on V4L2.)                             

-- 
Kind regards,
Sakari

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux