[linuxtv-media:master 478/479] drivers/media/usb/airspy/airspy.c:1084:1: warning: label 'err_unregister_v4l2_dev' defined but not used

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



tree:   git://linuxtv.org/media_tree.git master
head:   eca2d34b9d2ce70165a50510659838e28ca22742
commit: 785ef73dba6e9fefd2e5dd24546e0efa8698e5cd [478/479] [media] airspy: fix error logic during device register
config: i386-allmodconfig (attached as .config)
compiler: gcc-6 (Debian 6.1.1-1) 6.1.1 20160430
reproduce:
        git checkout 785ef73dba6e9fefd2e5dd24546e0efa8698e5cd
        # save the attached .config to linux build tree
        make ARCH=i386 

All warnings (new ones prefixed by >>):

   drivers/media/usb/airspy/airspy.c: In function 'airspy_probe':
>> drivers/media/usb/airspy/airspy.c:1084:1: warning: label 'err_unregister_v4l2_dev' defined but not used [-Wunused-label]
    err_unregister_v4l2_dev:
    ^~~~~~~~~~~~~~~~~~~~~~~

vim +/err_unregister_v4l2_dev +1084 drivers/media/usb/airspy/airspy.c

634fe5033 drivers/staging/media/airspy/airspy.c Antti Palosaari     2014-06-27  1068  	s->vdev.v4l2_dev = &s->v4l2_dev;
634fe5033 drivers/staging/media/airspy/airspy.c Antti Palosaari     2014-06-27  1069  	s->vdev.lock = &s->v4l2_lock;
634fe5033 drivers/staging/media/airspy/airspy.c Antti Palosaari     2014-06-27  1070  
634fe5033 drivers/staging/media/airspy/airspy.c Antti Palosaari     2014-06-27  1071  	ret = video_register_device(&s->vdev, VFL_TYPE_SDR, -1);
634fe5033 drivers/staging/media/airspy/airspy.c Antti Palosaari     2014-06-27  1072  	if (ret) {
617123ae3 drivers/media/usb/airspy/airspy.c     Antti Palosaari     2014-08-24  1073  		dev_err(s->dev, "Failed to register as video device (%d)\n",
634fe5033 drivers/staging/media/airspy/airspy.c Antti Palosaari     2014-06-27  1074  				ret);
785ef73db drivers/media/usb/airspy/airspy.c     James Patrick-Evans 2016-07-15  1075  		goto err_free_controls;
634fe5033 drivers/staging/media/airspy/airspy.c Antti Palosaari     2014-06-27  1076  	}
617123ae3 drivers/media/usb/airspy/airspy.c     Antti Palosaari     2014-08-24  1077  	dev_info(s->dev, "Registered as %s\n",
634fe5033 drivers/staging/media/airspy/airspy.c Antti Palosaari     2014-06-27  1078  			video_device_node_name(&s->vdev));
617123ae3 drivers/media/usb/airspy/airspy.c     Antti Palosaari     2014-08-24  1079  	dev_notice(s->dev, "SDR API is still slightly experimental and functionality changes may follow\n");
634fe5033 drivers/staging/media/airspy/airspy.c Antti Palosaari     2014-06-27  1080  	return 0;
634fe5033 drivers/staging/media/airspy/airspy.c Antti Palosaari     2014-06-27  1081  
634fe5033 drivers/staging/media/airspy/airspy.c Antti Palosaari     2014-06-27  1082  err_free_controls:
634fe5033 drivers/staging/media/airspy/airspy.c Antti Palosaari     2014-06-27  1083  	v4l2_ctrl_handler_free(&s->hdl);
634fe5033 drivers/staging/media/airspy/airspy.c Antti Palosaari     2014-06-27 @1084  err_unregister_v4l2_dev:
634fe5033 drivers/staging/media/airspy/airspy.c Antti Palosaari     2014-06-27  1085  	v4l2_device_unregister(&s->v4l2_dev);
634fe5033 drivers/staging/media/airspy/airspy.c Antti Palosaari     2014-06-27  1086  err_free_mem:
634fe5033 drivers/staging/media/airspy/airspy.c Antti Palosaari     2014-06-27  1087  	kfree(s);
634fe5033 drivers/staging/media/airspy/airspy.c Antti Palosaari     2014-06-27  1088  	return ret;
634fe5033 drivers/staging/media/airspy/airspy.c Antti Palosaari     2014-06-27  1089  }
634fe5033 drivers/staging/media/airspy/airspy.c Antti Palosaari     2014-06-27  1090  
634fe5033 drivers/staging/media/airspy/airspy.c Antti Palosaari     2014-06-27  1091  /* USB device ID list */
634fe5033 drivers/staging/media/airspy/airspy.c Antti Palosaari     2014-06-27  1092  static struct usb_device_id airspy_id_table[] = {

:::::: The code at line 1084 was first introduced by commit
:::::: 634fe5033951b80ef4b98d8f047cb1083d29170d [media] airspy: AirSpy SDR driver

:::::: TO: Antti Palosaari <crope@xxxxxx>
:::::: CC: Mauro Carvalho Chehab <m.chehab@xxxxxxxxxxx>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: Binary data


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux