Hello Shuah,
On 07/12/2016 08:33 PM, Shuah Khan wrote:
> Removing unnecessary error messages as appropriate error code is returned.
>
> Signed-off-by: Shuah Khan <shuahkh@xxxxxxxxxxxxxxx>
> ---
> drivers/media/platform/s5p-mfc/s5p_mfc.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc.c b/drivers/media/platform/s5p-mfc/s5p_mfc.c
> index b6fde20..906f80c 100644
> --- a/drivers/media/platform/s5p-mfc/s5p_mfc.c
> +++ b/drivers/media/platform/s5p-mfc/s5p_mfc.c
> @@ -759,7 +759,6 @@ static int s5p_mfc_open(struct file *file)
> /* Allocate memory for context */
> ctx = kzalloc(sizeof(*ctx), GFP_KERNEL);
> if (!ctx) {
> - mfc_err("Not enough memory\n");
I agree to remove this since in case of a OOM, the core already does a
stack dump and prints an error message so there's no need to it here.
> ret = -ENOMEM;
> goto err_alloc;
> }
> @@ -776,7 +775,6 @@ static int s5p_mfc_open(struct file *file)
> while (dev->ctx[ctx->num]) {
> ctx->num++;
> if (ctx->num >= MFC_NUM_CONTEXTS) {
> - mfc_err("Too many open contexts\n");
But I think this error message shouldn't be removed since explains why
the open failed, even when an error code is returned.
> ret = -EBUSY;
> goto err_no_ctx;
> }
>
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
