Em Sat, 18 Jun 2016 17:38:46 +0200 Pavel Machek <pavel@xxxxxx> escreveu: > Hi! > > > > Not V4L2_CID_USER_AD5820...? > > > > The rest of the controls have no USER as part of the macro name, so I > > wouldn't use it here either. > > Ok. > > > > Ok, separate header file for 2 lines seemed like a bit of overkill, > > > but why not. > > > > That follows an existing pattern of how controls have been implemented in > > other drivers. > > Ok. > > > Could you merge this with the driver patch? I've dropped that from my ad5820 > > branch as it does not compile. > > Yes, merged patch should be in your inbox now. The V4L2 core changes should be on a separate patch. Btw, you'll also need to patch documentation to reflect such changes. We're right now moving from DocBook to ReST markup language. The patches for it are right now on a separate topic branch (docs-next), to be merged for Kernel 4.8 on the next merge window. You should either base the patch on such branch or wait for it to be merged back mainstream to write such documentation additions. > > Thanks, > Pavel > -- Thanks, Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
