Re: [PATCH 06/11] media: adv7180: add bt.656-4 OF property

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 07/09/2016 11:59 AM, Steve Longerbeam wrote:


On 07/07/2016 07:52 AM, Lars-Peter Clausen wrote:
On 07/07/2016 12:59 AM, Steve Longerbeam wrote:
Add a device tree boolean property "bt656-4" to allow setting
the ITU-R BT.656-4 compatible bit.

Signed-off-by: Steve Longerbeam <steve_longerbeam@xxxxxxxxxx>

+    /* select ITU-R BT.656-4 compatible? */
+    if (of_property_read_bool(client->dev.of_node, "bt656-4"))
+        state->bt656_4 = true;
This property needs to be documented. In my opinion it should also be a
property of the endpoint sub-node rather than the toplevel device node since
this is a configuration of the endpoint format.

Agreed, it's really a config of the backend capture endpoint. I'll move it there and also document it in Documentation/devicetree/bindings/media/i2c/adv7180.txt.

er, scratch that. ITU-R BT.656 compatibility is really a property of the bt.656 bus. It should be added to v4l2 endpoints and parsed by v4l2_of_parse_endpoint(). I've created a patch to add a "bt656-mode" property to v4l2 endpoints and will copy all the maintainers.

Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux