The cec framework should not be build as a module if MEDIA_SUPPORT is set to built-in. Otherwise drivers that are built-in would not be able to reference the exported cec functions. So do the same as is done for the media controller in drivers/media/Makefile: make MEDIA_CEC a bool and use the same build mode as CONFIG_MEDIA_SUPPORT. Signed-off-by: Hans Verkuil <hans.verkuil@xxxxxxxxx> Reported-by: Arnd Bergmann <arnd@xxxxxxxx> --- diff --git a/drivers/staging/media/cec/Kconfig b/drivers/staging/media/cec/Kconfig index b83b4d8..c623bd3 100644 --- a/drivers/staging/media/cec/Kconfig +++ b/drivers/staging/media/cec/Kconfig @@ -1,5 +1,5 @@ config MEDIA_CEC - tristate "CEC API (EXPERIMENTAL)" + bool "CEC API (EXPERIMENTAL)" depends on MEDIA_SUPPORT depends on RC_CORE || !RC_CORE select MEDIA_CEC_EDID diff --git a/drivers/staging/media/cec/Makefile b/drivers/staging/media/cec/Makefile index 426ef73..bd7f3c5 100644 --- a/drivers/staging/media/cec/Makefile +++ b/drivers/staging/media/cec/Makefile @@ -1,3 +1,5 @@ cec-objs := cec-core.o cec-adap.o cec-api.o -obj-$(CONFIG_MEDIA_CEC) += cec.o +ifeq ($(CONFIG_MEDIA_CEC),y) + obj-$(CONFIG_MEDIA_SUPPORT) += cec.o +endif -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html