Re: [PATCH v2 1/2] solo6x10: Set FRAME_BUF_SIZE to 200KB

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Andrey,

Since you are the original author, can you give me your Signed-off-by line?

My apologies for the very late reply, it's been very busy lately and I am
finally catching up...

Thanks!

	Hans

On 05/04/2016 06:21 PM, Ismael Luceno wrote:
> From: Andrey Utkin <andrey.utkin@xxxxxxxxxxxxxxxxxxx>
> 
> Such frame size is met in practice. Also report oversized frames.
> 
> [ismael: Reworked warning and commit message]
> 
> Signed-off-by: Ismael Luceno <ismael@xxxxxxxxxxx>
> ---
>  drivers/media/pci/solo6x10/solo6x10-v4l2-enc.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/media/pci/solo6x10/solo6x10-v4l2-enc.c b/drivers/media/pci/solo6x10/solo6x10-v4l2-enc.c
> index 67a14c4..f98017b 100644
> --- a/drivers/media/pci/solo6x10/solo6x10-v4l2-enc.c
> +++ b/drivers/media/pci/solo6x10/solo6x10-v4l2-enc.c
> @@ -33,7 +33,7 @@
>  #include "solo6x10-jpeg.h"
>  
>  #define MIN_VID_BUFFERS		2
> -#define FRAME_BUF_SIZE		(196 * 1024)
> +#define FRAME_BUF_SIZE		(200 * 1024)
>  #define MP4_QS			16
>  #define DMA_ALIGN		4096
>  
> @@ -323,8 +323,11 @@ static int solo_send_desc(struct solo_enc_dev *solo_enc, int skip,
>  	int i;
>  	int ret;
>  
> -	if (WARN_ON_ONCE(size > FRAME_BUF_SIZE))
> +	if (WARN_ON_ONCE(size > FRAME_BUF_SIZE)) {
> +		dev_warn(&solo_dev->pdev->dev,
> +			 "oversized frame (%d bytes)\n", size);
>  		return -EINVAL;
> +	}
>  
>  	solo_enc->desc_count = 1;
>  
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux