Re: [PATCH 3/6] v4l: Add packed Bayer raw12 pixel formats

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Hans,

Thanks for the review!

Hans Verkuil wrote:
> On 05/27/2016 02:44 PM, Sakari Ailus wrote:
>> These formats are compressed 12-bit raw bayer formats with four different
>> pixel orders. They are similar to 10-bit variants. The formats added by
>> this patch are
>>
>> 	V4L2_PIX_FMT_SBGGR12P
>> 	V4L2_PIX_FMT_SGBRG12P
>> 	V4L2_PIX_FMT_SGRBG12P
>> 	V4L2_PIX_FMT_SRGGB12P
>>
>> Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>
>> ---
>>  .../DocBook/media/v4l/pixfmt-srggb12p.xml          | 103 +++++++++++++++++++++
>>  Documentation/DocBook/media/v4l/pixfmt.xml         |   1 +
>>  include/uapi/linux/videodev2.h                     |   5 +
>>  3 files changed, 109 insertions(+)
>>  create mode 100644 Documentation/DocBook/media/v4l/pixfmt-srggb12p.xml
>>
>> diff --git a/Documentation/DocBook/media/v4l/pixfmt-srggb12p.xml b/Documentation/DocBook/media/v4l/pixfmt-srggb12p.xml
>> new file mode 100644
>> index 0000000..affa366
>> --- /dev/null
>> +++ b/Documentation/DocBook/media/v4l/pixfmt-srggb12p.xml
>> @@ -0,0 +1,103 @@
>> +    <refentry id="pixfmt-srggb12p">
>> +      <refmeta>
>> +	<refentrytitle>V4L2_PIX_FMT_SRGGB12P ('pRCC'),
>> +	 V4L2_PIX_FMT_SGRBG12P ('pgCC'),
>> +	 V4L2_PIX_FMT_SGBRG12P ('pGCC'),
>> +	 V4L2_PIX_FMT_SBGGR12P ('pBCC'),
> 
> Nitpick: the last comma should be removed otherwise the title would end with it.
> 
> Looks good otherwise.
> 
> With the comma removed:
> 
> Acked-by: Hans Verkuil <hans.verkuil@xxxxxxxxx>

Indeed. Looks like this comes from the 10-bit definitions. I'll fix that
one as well.

-- 
Sakari Ailus
sakari.ailus@xxxxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux