Re: [PATCH 31/38] media: imx: Add video switch

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 06/16/2016 09:13 AM, Ian Arkver wrote:
For me this fails when I try to enable both video muxes (mx6dl, though mx6q should be the same).

I get a sysfs duplicate name failure for 34.videomux. I realise passing the GPR13 register offset and a bitfield mask as a tuple in the reg value of the of_node is handy, but how should we account for multiple devices with the same name and address?

A quick and dirty hack would be to have of_get_reg_field do something like

    field->reg = reg_bit_mask[0] & 0xff;

and then use values in the DT that differ in the bits masked off, but there must be a nicer way.

Trace below, fyi. This is from the v2 patches posted here, not your v2.1 tree.


Hi Ian,

Thanks for catching this. I found a simple and clean solution to this
problem: just rename the video-mux node from "videomux" to
"ipu[12]_csi[01]_mux". It makes the subdev names more descriptive
anyway. I've applied that change to my mx6-media-staging-v2.1
branch.

Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux