Hi Pavel, On Tue, May 31, 2016 at 11:34:37PM +0200, Pavel Machek wrote: > On Wed 2016-06-01 00:22:22, Sakari Ailus wrote: > > Hi Pavel, > > > > On Fri, May 27, 2016 at 10:51:40PM +0200, Pavel Machek wrote: > > > > > > This adds support for AD5820 autofocus coil, found for example in > > > Nokia N900 smartphone. > > > > > > Signed-off-by: Pavel Machek <pavel@xxxxxx> > > > > The patch looks good to me but then I came to think of a question I've > > missed so far: is there DT documentation somewhere for the properties used > > by the driver? I might put that to a separate patch, and cc the relevant > > list. > > Well, it does not use any dt properties. So there's not really much to > discuss with dt people... > > Maybe "ad5820" needs to go to list of simple i2c drivers somewhere, > but... It's an I2C device and it does use a regulator. Not a lot, though, these are both quite basic stuff. This should still be documented as the people who write the DT bindings (in general) aren't expected to read driver code as well. That's at least my understanding. -- Kind regards, Sakari Ailus e-mail: sakari.ailus@xxxxxx XMPP: sailus@xxxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
