On 05/23/2016 01:35 PM, David Binderman wrote: > Hello there, > > linux-next/drivers/media/v4l2-core/v4l2-ioctl.c:2174] -> > [linux-next/drivers/media/v4l2-core/v4l2-ioctl.c:2174]: (style) Same > expression on both sides of '&&'. > > Source code is > > if (WARN_ON(!ops->vidioc_cropcap && !ops->vidioc_cropcap)) > > Suggest either remove the duplication or test some other field. Yeah, it should have tested for vidioc_g_selection. Thanks for reporting this really dumb mistake! Will post a patch for this in a minute. Regards, Hans -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
