Re: [PATCH] tda18271 add FM filter selction + minor fixes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Sep 14, 2009 at 11:10 AM,  <spam@xxxxxxxxxxxxxxxxx> wrote:
> On Mon, Sep 14, 2009 at 08:33:46AM -0400, Michael Krufky wrote:
>> On Sun, Sep 13, 2009 at 8:14 PM,  <spam@xxxxxxxxxxxxxxxxx> wrote:
>> >
>> > This patch adds support for FM filter selection. The tda18271 has two rf
>> > inputs RF_IN (45-864 MHz) and FM_IN (65-108 MHz). The code automatically
>> > enables the antialiasing filter for radio reception and depending on the
>> > FM input selected configures EB23 register.
>> >
>> > Additional fixes:
>> > - Fixed the temerature comensation, see revision history of TDA18271HD_4
>> > ?spec.
>> > - Minor cosmetic change in the tda18271_rf_band[]
>> > - Fixed one value and removed a duplicate in tda18271_cid_target[]
>> >
>> > Signed-off-by: Henk.Vergonet@xxxxxxxxx
>> >
>> >
>>
>> Henk,
>>
>> Thank you for your patch.
>>
>> I have some other tda18271 patches pending merge currently, so it will
>> be a few days before I'll be able to test and merge your patch.
>>
>> In the meanwhile, I'd request that this single patch be broken down
>> into three separate patches, each with a description of the change and
>> sign-off.  I know that the patch you sent in is small, I just prefer
>> to apply changes separately.
>>
> Thats fine, I will wait for the pull in v4l-dvb and then redo the patches:
> - FM filter selection
> - Errata temerature compensation
> - Table fixes
>
> if thast ok.
>
>> Do you have FM radio working on the Zolid board after applying this?
>
> Unfortunately not yet, I get static noise with small 'ticks' at regular
> intervals. It maybe the way I am testing. Currently I am using:
>
>        mplayer radio://91.3/capture -nocache -rawaudio rate=32000 -radio \
>                adevice=hw=1.0:arate=32000
>
> to test.
>
> I will try to see if a can solder some pin headers on the card so I can
> use audio bypass to the sound card.

Henk,

Don't wait for them to be merged to v4l-dvb -- Just work against the
tda18271 development repository:

http://kernellabs.com/hg/~mkrufky/tda18271

I maintain this driver, and I actually have some other fixes with
respect to rf tracking filter calibration / compensation that I have
yet to push.  I'm asking you to resend your patches so that I'll queue
them for the next tda18271 merge.

Regards,

Mike
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux