Hello Arnd, Thanks for your feedback. On 05/02/2016 02:41 PM, Arnd Bergmann wrote: > On Monday 02 May 2016 13:27:54 Javier Martinez Canillas wrote: >> Failing to get the struct s5p_mfc_pm .clock is a non-fatal error so the >> clock field can have a errno pointer value. But s5p_mfc_final_pm() only >> checks if .clock is not NULL before attempting to unprepare and put it. >> >> This leads to the following warning in clk_put() due s5p_mfc_final_pm(): >> > > Better assign the pointer to NULL in case of a non-fatal error > return code. That way, the reader doesn't have to wonder why you > have the IS_ERR_OR_NULL() check here. > Ok, I'll re-spin the patch doing that instead. > Arnd > Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
