Hi Ivaylo, On Mon, Apr 25, 2016 at 12:08:04AM +0300, Ivaylo Dimitrov wrote: > From: Sakari Ailus <sakari.ailus@xxxxxx> > > Required added multiplier (and divisor) calculation did not take into > account the existing divisor when checking the values against the minimum > divisor. Do just that. > > Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxx> > --- > drivers/media/i2c/smiapp-pll.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/media/i2c/smiapp-pll.c b/drivers/media/i2c/smiapp-pll.c > index e3348db..5ad1edb 100644 > --- a/drivers/media/i2c/smiapp-pll.c > +++ b/drivers/media/i2c/smiapp-pll.c > @@ -227,7 +227,8 @@ static int __smiapp_pll_calculate( > > more_mul_factor = lcm(div, pll->pre_pll_clk_div) / div; > dev_dbg(dev, "more_mul_factor: %u\n", more_mul_factor); > - more_mul_factor = lcm(more_mul_factor, op_limits->min_sys_clk_div); > + more_mul_factor = lcm(more_mul_factor, > + DIV_ROUND_UP(op_limits->min_sys_clk_div, div)); > dev_dbg(dev, "more_mul_factor: min_op_sys_clk_div: %d\n", > more_mul_factor); > i = roundup(more_mul_min, more_mul_factor); I remember writing the patch, but I don't remember what for, or whether it was really needed. Does the secondary sensor work without this one? -- Sakari Ailus e-mail: sakari.ailus@xxxxxx XMPP: sailus@xxxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html