Re: [PATCH] hdpvr: i2c fixups for fully functional IR support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 09/01/2009 09:30 PM, Andy Walls wrote:
On Tue, 2009-09-01 at 10:19 -0400, Jarod Wilson wrote:
Patch is against http://hg.jannau.net/hdpvr/

1) Adds support for building hdpvr i2c support when i2c is built as a
module (based on work by David Engel on the mythtv-users list)

2) Refines the hdpvr_i2c_write() success check (based on a thread in
the sagetv forums)

With this patch in place, and the latest lirc_zilog driver in my lirc
git tree, the IR part in my hdpvr works perfectly, both for reception
and transmitting.

Signed-off-by: Jarod Wilson<jarod@xxxxxxxxxx>

Jarod,

I recall a problem Brandon Jenkins had from last year, that when I2C was
enabled in hdpvr, his machine with multiple HVR-1600s and an HD-PVR
would produce a kernel oops.

Have you tested this on a machine with both an HVR-1600 and HD-PVR
installed?

Hrm, no, haven't tested it with such a setup, don't have an HVR-1600. I do have an HVR-1250 that I think might suffice for testing though, if I'm thinking clearly.

Ugh. And I just noticed that while everything works swimmingly with a 2.6.30 kernel base, the i2c changes in 2.6.31 actually break it, so there's gonna be at least one more patch coming... I'm an idjit for not testing w/2.6.31 before sending this in, I *knew* there were major i2c changes to account for... (Its actually the hdpvr driver oopsing, before one even tries loading lirc_zilog).

--
Jarod Wilson
jarod@xxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux