Re: bug in pwc_set_shutter_speed v2.6.30.5 and fix

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sunday 23 August 2009 23:04:00 Jef Treece wrote:
> I found in recent kernel versions, I think somewhere between 2.6.29.3
> and 2.6.30.3, pwc_set_shutter_speed regressed.
>
> I was able to fix it with this one-line change
> (drivers/media/video/pwc/pwc-ctrl.c line 755 in 2.6.30.5 source):
>
> 	ret = send_control_msg(pdev,
> 		SET_LUM_CTL, SHUTTER_MODE_FORMATTER, &buf, sizeof(buf));
>
> change to
>
> 	ret = send_control_msg(pdev,
> 		SET_LUM_CTL, SHUTTER_MODE_FORMATTER, &buf, 1);
>
> I hope you find this information useful.

This indeed looks like a regression to me.

Martin, as you've introduced the problem, could you look into it and send a 
patch ? There might be other occurrences of wrong integer -> sizeof 
conversions, so please review them carefully.

-- 
Regards,

Laurent Pinchart
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux