David, Agree. I had posted a query and the suggestion I got was to use the patch for i2c mux support to implement this cleanly. But I didn't hear any plan to add this patch to upstream. This patch is already merged to v4l-dvb. I will work on a separate patch to move this code to a daughter card specific code. Murali Karicheri Software Design Engineer Texas Instruments Inc. Germantown, MD 20874 new phone: 301-407-9583 Old Phone : 301-515-3736 (will be deprecated) email: m-karicheri2@xxxxxx >-----Original Message----- >From: David Brownell [mailto:david-b@xxxxxxxxxxx] >Sent: Wednesday, August 19, 2009 5:04 PM >To: davinci-linux-open-source@xxxxxxxxxxxxxxxxxxxx >Cc: Karicheri, Muralidharan; linux-media@xxxxxxxxxxxxxxx >Subject: Re: [PATCH 3/5 - v3] DaVinci: platform changes to support vpfe >camera capture > >On Monday 17 August 2009, m-karicheri2@xxxxxx wrote: >> static struct i2c_board_info dm355evm_i2c_info[] = { >> { I2C_BOARD_INFO("dm355evm_msp", 0x25), >> .platform_data = dm355evm_mmcsd_gpios, >> }, >> + { >> + I2C_BOARD_INFO("PCA9543A", 0x73), >> + }, >> /* { plus irq }, */ >> /* { I2C_BOARD_INFO("tlv320aic3x", 0x1b), }, */ >> }; > >The DM355 EVM board has no PCA9543A I2C multiplexor >chip, so this is not a good approach to use. (*) > >If I understand correctly you are configuring some >particular add-on board, which uses a chip like that. >There are at least two such boards today, yes? And >potentially more. Don't preclude (or complicate) >use of different boards... > >The scalable approach is to have a file for each >daughtercard, and Kconfig options to enable the >support for those cards. The EVM board init code >might call a dm355evm_card_init() routine, and >provide a weak binding for it which would be >overridden by the > >- Dave > >(*) Separate issue: there's ongoing work to get the > I2C stack to support such chips in generic ways; > you should plan to use that work, which ISTR wasn't > too far from being mergeable. > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
