Hi Hans, Em Sun, 16 Aug 2009 09:42:20 +0200 Hans Verkuil <hverkuil@xxxxxxxxx> escreveu: > Hi Mauro, > > I've done a quick review of the text. See comments below. Thank you for the review! I've addressed your points. I'll commit it. Later, it can improved as needed. > > + <para>libv4lconvert/processing offers the actual video > > +processing functionality.</para> > > I hope that Hans or someone else can document the v4lconvert functions in > detail in the future. Yes, that would be great. > > +<link linkend='VIDIOC-ENUM-FMT'><constant>VIDIOC_ENUM_FMT</constant></link> keep > > +enumerating the hardware supported formats. > > "keeps". > > Actually, you might want to rewrite this ENUM_FMT description, since I'm not > quite sure what you want to say here. I think what you mean is something like > this: > > "VIDIOC_ENUM_FMT still enumerates the hardware supported formats, but the > emulated formats are added at the end." Ok, I changed it to: VIDIOC_ENUM_FMT keeps enumerating the hardware supported formats, plus the emulated formats offered by libv4l at the end. > The description of v4l2_fd_open is missing. Added, together with the get/set control functions. > > +counterparts, by using LD_PRELOAD=/usr/lib/v4l1compat.so.</para> > > + <para>It allows usage of binary legacy applications that > > +still don't use libv4l.</para> > > Is this description really correct? Based on the name of the wrapper I would > say that this is a library has something to do with V4L1 compatibility, yet > the description makes no mention of that. It also emulates V4L1 calls. Changed it to: This library intercepts calls to open/close/ioctl/mmap/mmunmap operations and redirects them to the libv4l counterparts, by using LD_PRELOAD=/usr/lib/v4l1compat.so. It also emulates V4L1 calls via V4L2 API. Cheers, Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
