Hello Hans, <snip> > > Hi Eduardo, > > I would like to make some small changes here: the control IDs do not have to > be consecutive so I think it is better to leave some gaps between the various > sections: e.g. let the AUDIO controls start at BASE + 64 (leaving more than > enough room for additional RDS controls). Between PTY and PS_NAME we should > skip one control since I'm sure at some time in the future a PTY_NAME will > appear. A comment like '/* placeholder for future PTY_NAME control */' would > be useful as well. I think leaving room for following controls would be good. No problem to leave some space left already in between these ID's. About the comment for PTY_NAME, I also agree with you. > > The AUDIO_COMPRESSION controls can start at BASE + 80, the PILOT controls at > BASE + 96 and the last set of controls at BASE + 112. Right. > > BTW, wouldn't it be slightly more consistent if V4L2_CID_FM_TX_PREEMPHASIS is > renamed to V4L2_CID_TUNE_PREEMPHASIS? It's a bit of an odd one out at the > moment. Right. Good. Better to aggregate it into the *_TUNE_* controls. Which makes sense for me. > > Note that I've verified my compat32 implementation for strings: it's working > correctly on my 64-bit machine (I hacked a string control into vivi.c to do > the testing). Right. > > If you agree with these proposed changes, then I can modify the patch myself, > no need for a new patch series. Ok then. You can proceed with these changes. No problem from my side. > > Regards, > > Hans BR, -- Eduardo Bezerra Valentin -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
