Re: [PULL] http://www.linuxtv.org/hg/~hverkuil/v4l-dvb

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Aug 07, 2009 at 04:33:53PM +0200, ext Hans Verkuil wrote:
> On Friday 07 August 2009 16:13:46 Mauro Carvalho Chehab wrote:
> > Em Thu, 6 Aug 2009 13:22:18 +0200
> > "Hans Verkuil" <hverkuil@xxxxxxxxx> escreveu:
> > 
> > > 
> > > > Em Sun, 2 Aug 2009 12:10:04 +0200
> > > > Hans Verkuil <hverkuil@xxxxxxxxx> escreveu:
> > > >
> > > >> Hi Mauro,
> > > >>
> > > >> Please pull from http://www.linuxtv.org/hg/~hverkuil/v4l-dvb for the
> > > >> following:
> > > >>
> > > >> - v4l: introduce string control support.
> 
> <snip>
> 
> > > > Why do you need two routines that will always return zero? Why to create a
> > > > code
> > > > that will never be used? v4l2-compat-ioctl32.c is already complex enough
> > > > without adding any bogus code.
> > > 
> > > When the RDS encoder driver from Eduardo is added, then he will add the
> > > string controls to ctrl_is_pointer() since his driver is the first to
> > > actually implement string controls.
> > 
> > It is better to add this together with his patch, since, currently, the code
> > makes no sense to anyone that are analyzing it. Btw, as this kind of controls
> > will be used firstly on his driver, please add his patches on your tree. This
> > will make easier to analyze the required core changes.
> 
> Eduardo, can you make a final patch series against my tree? I'll merge in your
> patches and make a new pull request containing everything.

Sure. I'll do it today. That will include that ordering change you request.

> 
> Regards,
> 
> 	Hans
> 
> -- 
> Hans Verkuil - video4linux developer - sponsored by TANDBERG Telecom

-- 
Eduardo Valentin
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux