On Thu, Aug 06, 2009 at 11:46:14AM -0700, David Xiao wrote: > On Thu, 2009-08-06 at 06:06 -0700, Laurent Pinchart wrote: > > Hi Ben, > > > > On Thursday 06 August 2009 13:46:19 Ben Dooks wrote: > > > On Thu, Aug 06, 2009 at 12:08:21PM +0200, Laurent Pinchart wrote: > > [snip] > > > > > > > > The second problem is to ensure cache coherency. As the userspace > > > > application will read data from the video buffers, those buffers will end > > > > up being cached in the processor's data cache. The driver does need to > > > > invalidate the cache before starting the DMA operation (userspace could > > > > in theory write to the buffers, but the data will be overwritten by DMA > > > > anyway, so there's no need to clean the cache). > > > > > > You'll need to clean the write buffers, otherwise the CPU may have data > > > queued that it has yet to write back to memory. > > > > Good points, thanks. > > I thought this should have been taken care of by the CPU specific > dma_inv_range routine. However, In arch/arm/mm/cache-v7.c, > v7_dma_inv_range does not drain the write buffer; and the > v6_dma_inv_range does that in the end of all the cache maintenance > operaitons. There's no such thing as "drain write buffer" in ARMv7. There are barriers instead, in particular dsb, which replaces the original "drain write buffer" instruction. As far as userspace DMA coherency, the only way you could do it with current kernel APIs is by using get_user_pages(), creating a scatterlist from those, and then passing it to dma_map_sg(). While the device has ownership of the SG, userspace must _not_ touch the buffer until after DMA has completed. However, that won't work with ARMv7's speculative prefetching. I'm afraid with such things, DMA direct into userspace mappings becomes a _lot_ harder, and lets face it, lots of Linux drivers just aren't going to bother supporting this - we can't currently get agreement to have an API to map DMA coherent pages into userspace! -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
