Re: [PATCH,RFC] Drop non-unlocked ioctl support in v4l2-dev.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Laurent,

> Hi everybody,
>
> this patch moves the BKL one level down by removing the non-unlocked ioctl
> in
> v4l2-dev.c and calling lock_kernel/unlock_kernel in the unlocked_ioctl
> handler
> if the driver only supports locked ioctl.
>
> Opinions/comments/applause/kicks ?

I've been thinking about this as well, and my idea was to properly
implement this by letting the v4l core serialize ioctls if the driver
doesn't do its own serialization (either through mutexes or lock_kernel).

The driver can just set a flag in video_device if it wants to do
serialization manually, otherwise the core will serialize using a mutex
and we should be able to completely remove the BKL from all v4l drivers.

I was actually planning an RFC for this myself, but you've beaten me to it
:-)

Regards,

         Hans

-- 
Hans Verkuil - video4linux developer - sponsored by TANDBERG

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux