Hello Mauro, I just noticed this patch: em28xx: fix: some webcams don't have audio inputs http://linuxtv.org/hg/v4l-dvb/rev/fe5eeff6644d I have to wonder what the EM28XX_R00_CHIPCFG contained on this particular device, since this cause should have already been handled by the elseif() block on line 507: } else if ((cfg & EM28XX_CHIPCFG_AUDIOMASK) == 0x00) { /* The device doesn't have vendor audio at all */ dev->has_alsa_audio = 0; dev->audio_mode.has_audio = 0; return 0; } On a related note, is there some rationale you can offer as to why you are committing patches directly into the v4l-dvb mainline without any peer review, unlike *every* other developer in the linuxtv project? I know it may seem redundant to you since you are the person acting on the PULL requests, but it would provide an opportunity for the other developers to offer comments on your patches *before* they go into the mainline. I for one have had to fix a number of regressions you introduced into the codebase which may have been avoided if the patches had been peer reviewed. Devin -- Devin J. Heitmueller - Kernel Labs http://www.kernellabs.com -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
