On Tue, Aug 4, 2009 at 3:58 PM, Alex Deucher<alexdeucher@xxxxxxxxx> wrote: > On Tue, Aug 4, 2009 at 3:50 PM, Michael Krufky<mkrufky@xxxxxxxxxxxxxx> wrote: >> On Tue, Aug 4, 2009 at 3:47 PM, Alex Deucher<alexdeucher@xxxxxxxxx> wrote: >>> On Tue, Aug 4, 2009 at 3:33 PM, Michael Krufky<mkrufky@xxxxxxxxxxx> wrote: >>>> Mauro, >>>> >>>> Please pull from: >>>> >>>> http://kernellabs.com/hg/~mkrufky/cx23885 >>>> >>>> for the following fixes: >>>> >>>> - cx23885: Enable mplayer pvr:// usage >>> >>> I'm not too familiar with mplayer's v4l support, but why not fix >>> mplayer rather than adding a fake audio interface to the driver. >>> Wouldn't that potentially confuse users or other apps? >> >> Thats a good question, Alex. >> >> The answer, for now, is conformity amongst the v4l2 drivers. >> >> Mplayer has been around for a good long time, and any v4l2 mpeg >> encoder that doesnt do this is broken in the vraious userspace >> applications. >> >> I agree that we should fix userspace also -- but fix the kernel first, >> so that older userspace works as-is. > > er... yeah, but you are re-enforcing broken behavior, rather than > "fixing" more drivers, why not submit a mplayer patch and tell users > they need a newer version of mplayer/etc. to work with their card? > Otherwise we'll end up with tons of drivers with fake audio interfaces > and mplayer will never get fixed and users will complain that the > audio interface doesn't work. You don't really have the full picture here, Alex. The applications expect to see an audio input, and rightfully so. This particular driver doesn't expose all of the functionality that is available from the raw video device onto the encoder device. Little by little, we are fixing up the cx23885-417 driver to fully expose all featuresets, but in the meanwhile, we do what is needed to make things work. The problem is not mplayer, the real problem is incomplete analog video (and analog audio) support in the cx23885 driver, itself. As THAT support improves, you will see small hacks like this disappear. This should be merged. Thanks for the feedback. Regards, Mike -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
